Skip to content

[FOLLOW-UP] HIVE-28373: Iceberg: Refactor the code of HadoopTableOptions#6345

Open
BsoBird wants to merge 4 commits intoapache:masterfrom
BsoBird:followup-HIVE-28373
Open

[FOLLOW-UP] HIVE-28373: Iceberg: Refactor the code of HadoopTableOptions#6345
BsoBird wants to merge 4 commits intoapache:masterfrom
BsoBird:followup-HIVE-28373

Conversation

@BsoBird
Copy link
Contributor

@BsoBird BsoBird commented Mar 3, 2026

What changes were proposed in this pull request?

Modify the test case to ensure it can run on macOS environments.

Why are the changes needed?

Since a considerable number of developers use macOS as their local development environment, the test case code should avoid relying on Linux-specific commands.

Does this PR introduce any user-facing change?

No

@BsoBird BsoBird marked this pull request as draft March 3, 2026 17:39
@BsoBird
1.use virtualThreadTaskExecutor
5d04e0d 
2.remove unnecessary casts
3.remove massive copy-paste
@deniskuzZ
Copy link
Member

deniskuzZ commented Mar 3, 2026 •
edited
Loading

@BsoBird this test fails most of the time for me.

failed on jenkins as well: https://ci.hive.apache.org/job/hive-precommit/job/PR-6345/1/testReport/junit/org.apache.iceberg.hadoop/TestHiveHadoopCommits/Testing___split_20___PostProcess___testTwoClientCommitSameVersion/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@BsoBird BsoBird marked this pull request as ready for review March 5, 2026 10:20
@BsoBird
Copy link
Contributor Author

BsoBird commented Mar 5, 2026

@deniskuzZ
Hello, I've updated the test code for cross-platform stability.
The root cause was that macOS lacks the renameat2 syscall available in Linux, forcing rename to follow basic POSIX behavior (overwriting targets). To eliminate these filesystem behavioral differences between test environments, I've moved the rename logic into Java code to simulate HDFS rename semantics.

deniskuzZ
deniskuzZ reviewed Mar 10, 2026
View reviewed changes
iceberg/iceberg-catalog/src/test/java/org/apache/iceberg/hadoop/TestHiveHadoopCommits.java
};

Tasks.range(2)
.executeWith(executorService)
Copy link
Member

@deniskuzZ deniskuzZ Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many spaces

deniskuzZ
deniskuzZ approved these changes Mar 10, 2026
View reviewed changes
Copy link
Member

@deniskuzZ deniskuzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deniskuzZ deniskuzZ deniskuzZ approved these changes

Assignees

No one assigned

Labels

tests passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BsoBird @deniskuzZ @asf-ci-hive